WIP: rename fontawesome icons to v6 #1394
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 3c4cb0f |
philli-m
suggested changes
Apr 19, 2023
Contributor
philli-m
left a comment
philli-m
left a comment
There was a problem hiding this comment.
as we are touching all the files anyway I would update all classes to their current naming convention
adhocracy4/comments_async/static/comments_async/filter_search.jsx
Outdated
Show resolved
Hide resolved
goapunk
changed the title
* rename fas -> fa-solid * rename far -> fa-regular
goapunk
force-pushed
the
jd-2023-04-fontawesome-6
branch
from
c39aedb to
2e405d6
Compare
goapunk
changed the title
goapunk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires updating to fontawesome v6 in all projects